Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Logger #341

Merged
merged 6 commits into from
May 27, 2022
Merged

feat: add Logger #341

merged 6 commits into from
May 27, 2022

Conversation

aallam
Copy link
Member

@aallam aallam commented May 25, 2022 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related Issue n/a
Need Doc update no

Describe your change

  • Allow providing custom Logger to the client
  • Additionally, provide:
    • Logger.Simple: log using println (default)
    • Logger.Empty: no op
    • Logger.messageLengthLimiting(): breaks up log messages into multiple logs
    • Logger.Slf4j (jvm): log using slf4j

@aallam aallam merged commit 6ea9143 into master May 27, 2022
@aallam aallam deleted the feat/logger branch May 27, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aallam