Skip to content

Commit

Permalink
feat(core): skip onInput on keyboard select with URL
Browse files Browse the repository at this point in the history
  • Loading branch information
francoischalifour committed Sep 25, 2020
1 parent b10fbe1 commit 399be2b
Showing 1 changed file with 24 additions and 8 deletions.
32 changes: 24 additions & 8 deletions packages/autocomplete-core/src/onKeyDown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,30 @@ export function onKeyDown<TItem>({
} else if (event.altKey) {
// Keep native browser behavior
} else {
if (itemUrl !== undefined) {
source.onSelect({
suggestion: item,
suggestionValue: itemValue,
suggestionUrl: itemUrl,
source,
state: store.getState(),
setHighlightedIndex,
setQuery,
setSuggestions,
setIsOpen,
setStatus,
setContext,
event,
});
props.navigator.navigate({
suggestionUrl: itemUrl,
suggestion: item,
state: store.getState(),
});

return;
}

onInput({
query: itemValue,
event,
Expand Down Expand Up @@ -190,14 +214,6 @@ export function onKeyDown<TItem>({
event,
});
});

if (itemUrl !== undefined) {
props.navigator.navigate({
suggestionUrl: itemUrl,
suggestion: item,
state: store.getState(),
});
}
}
}
}

0 comments on commit 399be2b

Please sign in to comment.