Skip to content

Commit

Permalink
fix(algolia): fix getAlgoliaResults typing
Browse files Browse the repository at this point in the history
This fixes some wrong types in the `getAlgoliaResults` function. We now make sure to receive records as inputs and to return hits (being their returned value with highlighting and snipetting).
  • Loading branch information
francoischalifour committed Oct 10, 2020
1 parent 263c8d6 commit a2200cf
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ import { Hit } from '@algolia/client-search';

import { search, SearchParams } from './search';

export function getAlgoliaHits<THit>({
export function getAlgoliaHits<TRecord>({
searchClient,
queries,
}: SearchParams): Promise<Array<Array<Hit<THit>>>> {
return search<THit>({ searchClient, queries }).then((response) => {
}: SearchParams): Promise<Array<Array<Hit<TRecord>>>> {
return search<TRecord>({ searchClient, queries }).then((response) => {
const results = response.results;

return results.map((result) => result.hits);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { MultipleQueriesResponse } from '@algolia/client-search';
import { SearchResponse } from '@algolia/client-search';

import { search, SearchParams } from './search';

export function getAlgoliaResults<THit>({
export function getAlgoliaResults<TRecord>({
searchClient,
queries,
}: SearchParams): Promise<MultipleQueriesResponse<THit>['results']> {
return search<THit>({ searchClient, queries }).then((response) => {
}: SearchParams): Promise<Array<SearchResponse<TRecord>>> {
return search<TRecord>({ searchClient, queries }).then((response) => {
return response.results;
});
}
4 changes: 2 additions & 2 deletions packages/autocomplete-preset-algolia/src/search/search.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ export interface SearchParams {
queries: MultipleQueriesQuery[];
}

export function search<THit>({ searchClient, queries }: SearchParams) {
export function search<TRecord>({ searchClient, queries }: SearchParams) {
if (typeof searchClient.addAlgoliaAgent === 'function') {
searchClient.addAlgoliaAgent('autocomplete-core', version);
}

return searchClient.search<THit>(
return searchClient.search<TRecord>(
queries.map((searchParameters) => {
const { indexName, query, params } = searchParameters;

Expand Down

0 comments on commit a2200cf

Please sign in to comment.