Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop touchstart event propagation if coming from cancel button in detached mode #924

Merged
merged 12 commits into from
Mar 31, 2022
Merged

fix: stop touchstart event propagation if coming from cancel button in detached mode #924

merged 12 commits into from
Mar 31, 2022

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Mar 24, 2022

Changes in #922 did not resolve the initial issue, as tests were using autocomplete debug which falsified the outcome.

This PR directly prevents search input blur event from closing the autocomplete panel when detached.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 24, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05032e9:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
algolia/autocomplete Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

francoischalifour
francoischalifour reviewed Mar 24, 2022
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test change?

packages/autocomplete-js/src/autocomplete.ts Outdated Show resolved Hide resolved
francoischalifour
francoischalifour reviewed Mar 25, 2022
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution looks better. Can we update the tests?

@dhayab dhayab changed the title fix: prevent search input blur from closing panel in detached mode fix: stop touchstart event propagation if coming from cancel button in detached mode Mar 25, 2022
@dhayab dhayab enabled auto-merge (squash) March 31, 2022 09:32
@dhayab dhayab merged commit 24cf9d6 into next Mar 31, 2022
@dhayab dhayab deleted the fix/input-blur-detached branch March 31, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahdayan sarahdayan sarahdayan approved these changes

@francoischalifour francoischalifour francoischalifour approved these changes

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhayab @sarahdayan @francoischalifour @Haroenv