Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent event bubbling on cancel button click #922

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Mar 22, 2022

In detached mode, the cancel button does not stop event propagation on click, which might cause misclicks in elements that are under the overlay when the latter disappears.

Closes #853

@dhayab dhayab requested review from a team, FabienMotte, Haroenv and francoischalifour and removed request for a team March 22, 2022 11:17
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 22, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc6611e:

Sandbox Source
algolia/autocomplete Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
algolia/autocomplete Configuration
@algolia/autocomplete-example-react-renderer Configuration
algolia/autocomplete Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this required for other clicks as well, or can they be considered isolated?

packages/autocomplete-js/src/createAutocompleteDom.ts Outdated Show resolved Hide resolved
@dhayab
Copy link
Member Author

dhayab commented Mar 22, 2022

@Haroenv it does not seem to concern items inside the panel, I think it is isolated indeed.

@dhayab dhayab merged commit ba17ccd into next Mar 23, 2022
@dhayab dhayab deleted the fix/stop-event-bubble-cancel-button branch March 23, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elements behind detached overlay cancel button get clicked as well
3 participants