Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add vue instantsearch example #892

Merged
merged 8 commits into from
Feb 10, 2022

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Feb 9, 2022

This PR adds an example showing how to integrate Autocomplete within a Vue InstantSearch environment.

It will be referenced in an upcoming guide which will be similar to Using Autocomplete with InstantSearch.

Sandbox →

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d7303f:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
algolia/autocomplete Configuration
algolia/autocomplete Configuration
@algolia/autocomplete-example-vue Configuration
@algolia/autocomplete-example-vue-instantsearch PR

@dhayab dhayab marked this pull request as ready for review February 9, 2022 11:12
@dhayab dhayab requested review from a team, FabienMotte, Haroenv and sarahdayan and removed request for a team February 9, 2022 11:12
@dhayab
Copy link
Member Author

dhayab commented Feb 9, 2022

I bootstrapped this example with vue3-vue-cli from our doc-code-samples, but I'm wondering if I should base it on vite. I don't have a broad knowledge on the Vue ecosystem, what are you thoughts on that?

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, but wondering if it should be split, what do you think?

examples/vue-instantsearch/src/App.vue Outdated Show resolved Hide resolved
examples/vue-instantsearch/src/App.vue Outdated Show resolved Hide resolved
examples/vue-instantsearch/src/instantsearch.js Outdated Show resolved Hide resolved
Copy link
Member

@sarahdayan sarahdayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 💚

.codesandbox/ci.json Outdated Show resolved Hide resolved
examples/vue-instantsearch/src/constants.js Outdated Show resolved Hide resolved
@dhayab dhayab enabled auto-merge (squash) February 10, 2022 10:58
@dhayab dhayab merged commit 4430816 into next Feb 10, 2022
@dhayab dhayab deleted the docs/vue-instantsearch-example branch February 10, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants