fix: support Chrome autofill when event.key is undefined (#1888)

* fix: event.key is undefined #1887 * Update packages/docsearch-react/src/useDocSearchKeyboardEvents.ts Co-authored-by: François Chalifour <[email protected]> --------- Co-authored-by: François Chalifour <[email protected]>
algolia · May 17, 2023 · 3f15fdb · 3f15fdb
1 parent bae117c
commit 3f15fdb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -15,10 +15,11 @@ dist/
 
 # IDE
 .vscode/
+.idea
 
 # Environment files
 .env
 
 # Cypress Video and Screenshots output
 cypress/screenshots/
-cypress/videos/
+cypress/videos/
diff --git a/packages/docsearch-react/src/useDocSearchKeyboardEvents.ts b/packages/docsearch-react/src/useDocSearchKeyboardEvents.ts
@@ -39,7 +39,11 @@ export function useDocSearchKeyboardEvents({
       if (
         (event.keyCode === 27 && isOpen) ||
         // The `Cmd+K` shortcut both opens and closes the modal.
-        (event.key.toLowerCase() === 'k' && (event.metaKey || event.ctrlKey)) ||
+        // We need to check for `event.key` because it can be `undefined` with
+        // Chrome's autofill feature.
+        // See https://github.com/paperjs/paper.js/issues/1398
+        (event.key?.toLowerCase() === 'k' &&
+          (event.metaKey || event.ctrlKey)) ||
         // The `/` shortcut opens but doesn't close the modal because it's
         // a character.
         (!isEditingContent(event) && event.key === '/' && !isOpen)