Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamicWidgets): prevent calling of "render" when widgets are not yet added #4997

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jan 24, 2022

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8768e4:

Sandbox Source
InstantSearch.js Configuration
InstantSearch.js (forked) PR

@Haroenv Haroenv force-pushed the feat/dynamic-widgets-prevent-fake-render branch from 064343c to a8768e4 Compare December 1, 2022 12:52
@Haroenv Haroenv force-pushed the feat/dynamic-widgets-prevent-fake-render branch from a8768e4 to 00d1713 Compare January 23, 2023 15:31
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d1cb10:

Sandbox Source
InstantSearch.js Configuration
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-vue-instantsearch-default-theme Configuration
InstantSearch.js (forked) PR

@Haroenv
Copy link
Contributor Author

Haroenv commented Dec 7, 2023

This would also solve infinite hits rendering with wrong results and messing up the cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant