refactoring: move show more count tests to common suite #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
commented
May 22, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 245aa81:
|
Haroenv
reviewed
May 22, 2023
Haroenv
reviewed
May 23, 2023
| @@ -61,7 +61,6 @@ export function createShowMoreTests(setup: HierarchicalMenuSetup, act: Act) { | |||
| limit, | |||
| showMoreLimit, | |||
| showMore: true, | |||
| // InstantSearch.js | |||
| templates: { | |||
There was a problem hiding this comment.
this is good, but should the source of truth be templates or translations? I guess it's fine either way though, depends where we consider the translation
Haroenv
approved these changes
May 24, 2023
mikedavis77
deleted the
feat/refinement-list-show-more-count-common-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stacked PR for #5593 that moves unit tests into the common suite.
Vue tests are expected to fail until implementation works on base branch.