This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
chore: remove jest notifications #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
approved these changes
Apr 12, 2017
package.json
Outdated
| @@ -119,12 +119,9 @@ | |||
| "engines": { | |||
| "node": "^6.x.x || ^7.x.x" | |||
| }, | |||
| "jest": { | |||
| "notify": true | |||
There was a problem hiding this comment.
What about notify: false to remind us that we want to enable it again later?
See: jestjs/jest#3177 On OSX and watch mode, if a test is failing, the terminal-notifier process stays open.
mthuret
force-pushed
the
chore/remove-notify
branch
from
79e95a1
to
3f86fe7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: jestjs/jest#3177
On OSX and watch mode, if a test is failing, the terminal-notifier process stays open.