Defer to model's way of limiting the model set #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow optimization per model
Avoid indexing models you don't want to be indexed anymore.
When the indexing process hits
shouldBeSearchable
it is already iterating through a lot of "probably" unnecessary models.Describe your change
When using aggregators, this implelents
MakeAllSearchable
independently of how each model is implementing it.What problem is this fixing?
At the moment, this only looks for soft deletes in order to limit the set algolia needs to evaluate before indexing it.
With this change, the aggregator will look for a per model implementation of
MakeAllSearchableUsing
in order for add extra rules to limit the set Algolia need to iterate to index.