Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the challenge 4 bug #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

niel98
Copy link

@niel98 niel98 commented Apr 1, 2024

Fix the Bug Submission Pull Request

What was the bug?

The bug was trying to group two automatically payment transactions and send them using atomic transfers but passing the wrong value to the signer when adding the transaction. The sender account was being passed instead of the signer and that triggered the bug of Account not assignable to Transaction signer

How did you fix the bug?

I created an account signer for the sender account on line 45 and then passed that signer value to the signer instead of passing the sender's account.

Console Screenshot:

Screenshot 2024-04-01 at 13 25 03

@iskysun96 iskysun96 added the Approved ✅ Successfully completed the challenge! label Apr 1, 2024
@iskysun96
Copy link
Contributor

🎉 Congrats on solving the 4th Algorand Coding Challenge!

I have labeled your PR approved, so you can now claim your certificate.

You can claim your certificate of completion NFT here:
https://goplausible.xyz/claim/8x3aqnmh7p2wf25dvmxz7ksvjs3gr02d6648tf31ny90wwtams53jvssjwcj2bgfs7qr425958h3abw83a33t3tdbqb0sjtntmta82r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ Successfully completed the challenge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants