Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set conduit data dir through env var in entrypoint script #154

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

cshintov
Copy link
Contributor

Use CONDUIT_DATA_DIR in the entrypoint script for docker.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2023

CLA assistant check
All committers have signed the CLA.

@cshintov cshintov changed the title Set conduit data dir through env var Set conduit data dir through env var in entrypoint script Oct 10, 2023
@winder winder self-requested a review October 12, 2023 15:09
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #154 (d3d5767) into master (442791a) will increase coverage by 5.23%.
Report is 64 commits behind head on master.
The diff coverage is 82.80%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   67.66%   72.89%   +5.23%     
==========================================
  Files          32       38       +6     
  Lines        1976     2789     +813     
==========================================
+ Hits         1337     2033     +696     
- Misses        570      646      +76     
- Partials       69      110      +41     
Files Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/init_provider.go 100.00% <100.00%> (ø)
conduit/loggers/loggers.go 91.89% <100.00%> (+0.22%) ⬆️
conduit/metrics/metrics.go 100.00% <ø> (ø)
conduit/pipeline/common.go 90.62% <100.00%> (+65.62%) ⬆️
conduit/pipeline/errors.go 100.00% <100.00%> (ø)
conduit/pipeline/logging.go 100.00% <100.00%> (ø)
conduit/pipeline/metadata.go 73.52% <ø> (+4.41%) ⬆️
conduit/plugins/config.go 100.00% <ø> (ø)
conduit/plugins/exporters/exporter_factory.go 100.00% <100.00%> (ø)
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the fix. If you'd like to contribute another PR, the Indexer image is virtually identical to this one. The same fix applies there.

@winder winder merged commit 3357b40 into algorand:master Oct 13, 2023
4 checks passed
@cshintov
Copy link
Contributor Author

Yup. Saw it. Was thinking to raise a PR for that as well. Thanks for the merge 🙂 !

@cshintov
Copy link
Contributor Author

Done. algorand/indexer#1583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants