algod importer: Fix archival mode and update tests. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
commented
Apr 14, 2023
| algodServer: NewAlgodServer(GenesisResponder, | ||
| BlockResponder, | ||
| BlockAfterResponder, | ||
| MakeSyncRoundResponder(http.StatusNotFound))}, |
There was a problem hiding this comment.
Most of these http.StatusOK to http.StatusNotFound changes led to tests that fail without the bugfix.
algochoi
reviewed
Apr 14, 2023
tzaffi
reviewed
Apr 14, 2023
algochoi
reviewed
Apr 18, 2023
algochoi
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When adding in the recent follow mode automation the algod import mode the archival configuration was not accounted for. A bug in the unit test which treated sync calls to be treated as no-ops instead of not found errors allowed the regression to be missed.
Test Plan
Update archival mode unit tests to return a 404 when sync endpoints are called to properly reflect the behavior of an archival node.