Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors(postgresql): Clarify missing ledger state delta message. #6

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Mar 10, 2023

Summary

If the postgresql exporter is given a block without a ledger state delta object, the error message gave no indication about what the user should do. Attempt to clarify the situation by telling the user to check that their algod importer is in follower mode.

Test Plan

Update existing unit test.

@winder winder self-assigned this Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@f5c2701). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage          ?   66.64%           
=========================================
  Files             ?       32           
  Lines             ?     1805           
  Branches          ?        0           
=========================================
  Hits              ?     1203           
  Misses            ?      535           
  Partials          ?       67           
Impacted Files Coverage Δ
...lugins/exporters/postgresql/postgresql_exporter.go 78.20% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder merged commit 4179564 into master Mar 10, 2023
@winder winder deleted the will/error-message branch March 10, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants