-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Migrate CircleCI automation to github actions. #62
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 67.66% 69.40% +1.74%
==========================================
Files 32 33 +1
Lines 1976 2056 +80
==========================================
+ Hits 1337 1427 +90
+ Misses 570 554 -16
- Partials 69 75 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'll need to update the project's CI requirements after this is merged. |
@@ -0,0 +1,54 @@ | |||
name: Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They weren't being run.
The difference compared to the on-commit tests are:
- CHANNEL=stable
+ CHANNEL=nightly
and maybe:
- FILENAME="fa6ad40d/rel-nightly
+ FILENAME="rel-nightly"
I tried to make the workflow parameterized in this PR but it wasn't working. Agreed about bringing them back in the future. This is the same problem we have in SDKs: what version of algod should we be testing against?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @cce we've talked about this before, you might be curious. This is one way we pin versions between repositories. It means there is a gap where we don't know if the downstream tools are still compatible with algod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Migrate CircleCI automation to github actions.
Test Plan
Verify that this PR trigger the new automation, and the automation runs correctly.