Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate CircleCI automation to github actions. #62

Merged
merged 20 commits into from
Apr 26, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Apr 25, 2023

Summary

Migrate CircleCI automation to github actions.

Test Plan

Verify that this PR trigger the new automation, and the automation runs correctly.

@tzaffi

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #62 (3f891af) into master (442791a) will increase coverage by 1.74%.
The diff coverage is 71.27%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   67.66%   69.40%   +1.74%     
==========================================
  Files          32       33       +1     
  Lines        1976     2056      +80     
==========================================
+ Hits         1337     1427      +90     
+ Misses        570      554      -16     
- Partials       69       75       +6     
Impacted Files Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...lugins/exporters/postgresql/postgresql_exporter.go 66.66% <51.21%> (-11.54%) ⬇️
conduit/pipeline/pipeline.go 66.09% <72.10%> (+0.64%) ⬆️
conduit/data/config.go 76.47% <76.47%> (ø)
conduit/plugins/importers/algod/algod_importer.go 88.36% <76.47%> (+0.05%) ⬆️
conduit/pipeline/errors.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder requested review from Eric-Warehime and a team April 25, 2023 21:15
@winder
Copy link
Contributor Author

winder commented Apr 25, 2023

I'll need to update the project's CI requirements after this is merged.

@@ -0,0 +1,54 @@
name: Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the nightly tests?
image
Seems like they were identical to the on-commit tests (if they were even being run) so it's fine by me. If in the future we need to revive them, we can.

Copy link
Contributor Author

@winder winder Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They weren't being run.

The difference compared to the on-commit tests are:

- CHANNEL=stable
+ CHANNEL=nightly

and maybe:

- FILENAME="fa6ad40d/rel-nightly
+ FILENAME="rel-nightly"

I tried to make the workflow parameterized in this PR but it wasn't working. Agreed about bringing them back in the future. This is the same problem we have in SDKs: what version of algod should we be testing against?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @cce we've talked about this before, you might be curious. This is one way we pin versions between repositories. It means there is a gap where we don't know if the downstream tools are still compatible with algod.

Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winder winder merged commit 585a568 into algorand:master Apr 26, 2023
@winder winder deleted the will/gh-actions branch April 26, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants