-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: indexer import types #73
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 67.66% 69.05% +1.39%
==========================================
Files 32 36 +4
Lines 1976 2414 +438
==========================================
+ Hits 1337 1667 +330
- Misses 570 654 +84
- Partials 69 93 +24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -59,6 +59,7 @@ var ignoreTags = map[string]bool{ | |||
"txn.apap": true, | |||
"txn.apsu": true, | |||
"dt.lg": true, | |||
"dt.sa": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot handle this slice type EvalDelta.SharedAccounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go after changing the Go SDK hash
Handle type update and pass indexer E2E tests
This PR results from fixing the type inconsistency for
EvalDelta
ingo-algorand-sdk
(algorand/go-algorand-sdk#531) and passing the failing nightly test in indexer.NOTE:
This should not be merged until algorand/go-algorand-sdk#531 is merged and the
go.mod
in this project is updated.