Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Verbose Test Harness #540

Merged
merged 24 commits into from
May 24, 2023
Merged

enhancement: Verbose Test Harness #540

merged 24 commits into from
May 24, 2023

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented May 22, 2023

Summary

To improve visibility of C.I. build failures, utilize new logging capabilities in the sandbox (algorand/sandbox#181) and set VERBOSE_HARNESS=1.

In particular we can now see:

  • traces of the docker compose up command
  • dumped docker-compose logs for:
    • indexer-db
    • algod
    • indexer

TODO

What does a successful build look like?

See for example this build. You'll need to download Circle's log as the max display at Circle is 400K characters.

What does a failed build look like?

As a test case I pinned the companion algorand-sdk-testing PR (algorand/algorand-sdk-testing#288) to a broken indexer commit. The build broke early enough to see the entire logs directly on circle. There are two highlights to look for:

  1. We can see the usual error information one or more services failed to start
  2. Then the docker compose logs are dumped for each of the services and at the end we see could not load genesis...

@tzaffi tzaffi changed the title Verbose-harness enhancement: Verbose Test Harness May 23, 2023
@tzaffi tzaffi added tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead Enhancement and removed tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead labels May 23, 2023
@tzaffi tzaffi changed the base branch from develop to txn-deltas-api May 23, 2023 03:29
README.md Show resolved Hide resolved
@tzaffi tzaffi marked this pull request as ready for review May 23, 2023 04:36
README.md Show resolved Hide resolved
.test-env Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.test-env Outdated Show resolved Hide resolved
Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you just need to update the sdk testing branch to master

Base automatically changed from txn-deltas-api to develop May 24, 2023 18:28
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to update the branch.

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! very helpful for debugging

@tzaffi tzaffi merged commit e14a13d into develop May 24, 2023
@tzaffi tzaffi deleted the verbose-harness branch May 24, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants