Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Account Balance checks for expiration tests #3042

Closed
AlgoStephenAkiki opened this issue Oct 12, 2021 · 0 comments · Fixed by #3043
Closed

Remove Account Balance checks for expiration tests #3042

AlgoStephenAkiki opened this issue Oct 12, 2021 · 0 comments · Fixed by #3043
Assignees
@AlgoStephenAkiki
Labels
Team Carbon-11

Comments

@AlgoStephenAkiki
Copy link
Contributor

AlgoStephenAkiki commented Oct 12, 2021 •
edited
Loading

For TestParticipationAccountsExpirationFuture and TestParticipationAccountsExpirationNonFuture, remove the tests on account balances since they are irrelevant to the test (and potentially cause spurious test failures).
@AlgoStephenAkiki AlgoStephenAkiki self-assigned this Oct 12, 2021
@AlgoStephenAkiki AlgoStephenAkiki mentioned this issue Oct 12, 2021
Merged
tsachiherman pushed a commit that referenced this issue Oct 12, 2021
@AlgoStephenAkiki
testing: remove redundant checking from TestParticipationAccountsExpi…
e86c53f 
…rationFuture (#3043)

## Summary

Reduce unneeded tests from TestParticipationAccountsExpirationFuture.

Resolves #3042

## Test Plan

This is a test
cce pushed a commit to cce/go-algorand that referenced this issue Oct 28, 2021
@AlgoStephenAkiki @cce
testing: remove redundant checking from TestParticipationAccountsExpi…
d84a64e 
…rationFuture (algorand#3043)

## Summary

Reduce unneeded tests from TestParticipationAccountsExpirationFuture.

Resolves algorand#3042

## Test Plan

This is a test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlgoStephenAkiki AlgoStephenAkiki

Labels
Team Carbon-11
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testing: remove redundant checking from TestParticipationAccountsExpirationFuture
1 participant
@AlgoStephenAkiki