Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move ledger/internal to non-internal location #4778

Closed
michaeldiamant opened this issue Nov 9, 2022 · 1 comment
Closed

Refactor: Move ledger/internal to non-internal location #4778

michaeldiamant opened this issue Nov 9, 2022 · 1 comment
Labels
Team Carbon-11 Team Scytale

Comments

@michaeldiamant
Copy link
Contributor

Problem

On several occasions, the lack of visibility in ledger/internal caused friction. Since there's been no convincing rationale to keep the internal package, the story requests moving ledger/internal files into a non-internal location (presumably, ledger/).

Solution

Dependencies

Urgency
@michaeldiamant michaeldiamant linked a pull request Nov 9, 2022 that will close this issue
ledger: rename "internal" package to "eval" #4777
Closed
@jsgranados
Copy link
Contributor

Closing. This issue was addressed with #5236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team Carbon-11 Team Scytale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ledger: rename "internal" package to "eval" winder/go-algorand
2 participants
@michaeldiamant @jsgranados