ledger: rename "internal" to "eval" #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
requested review from
winder,
Eric-Warehime,
shiqizng,
jannotti and
algorandskiy
Codecov Report
@@ Coverage Diff @@
## master #5236 +/- ##
==========================================
- Coverage 53.56% 53.54% -0.02%
==========================================
Files 441 441
Lines 55137 55137
==========================================
- Hits 29534 29524 -10
- Misses 23320 23326 +6
- Partials 2283 2287 +4
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
previously approved these changes
Mar 28, 2023
ledger/eval/appcow.go
Outdated
| @@ -29,7 +29,7 @@ import ( | |||
| "github.com/algorand/go-algorand/protocol" | |||
| ) | |||
|
|
|||
| //msgp: ignore storageAction | |||
| // msgp: ignore storageAction | |||
There was a problem hiding this comment.
Was this space an accident?
There was a problem hiding this comment.
I think Goland must have done some format-before-save changes when I used the package rename refactor tool ... I can fix
There was a problem hiding this comment.
also there was an issue that this should have been //msgp:ignore instead of //msgp: ignore even before this PR..
Eric-Warehime
previously approved these changes
Mar 29, 2023
Eric-Warehime
approved these changes
Mar 29, 2023
winder
approved these changes
Mar 29, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Picking up from #4272 and #4777, this makes the block evaluator importable by external tools and programs.
Test Plan
Rename only, existing tests should pass.