Convenient and High-fidelity Transaction Processing Tests #2730
Conversation
jannotti
force-pushed
the
txn-eval-testing
branch
from
447c46e
to
a3129f6
Compare
This refactors some of the `ledger` code so that it's convenient to write short tests that operate on a fairly complete ledger, including rewards payouts. Previously, tests used genesis(), but genesis() build the genesis block internally "by hand" rather than using MakeGenesisBlock, so it missed some details (like setting up RewardsState). Presumably, this was because MakeGenesisBlock was in the `data` package, and could not be imported. That is the motivation behind moving it, and some related code, to bookkeeping (where various Genesis related code already existed). The txntest packaged is motivated purely by a desire for more concise tests. It allows for the construction of transaction.Transaction objects concisely, and we can add all sort of conveneince routines here that would not make sense in the production code (turning these into SignedTxns, SignedTxnWithADs, TransactionGroups, etc).
| return ad | ||
| } | ||
|
|
||
| func (eval *BlockEvaluator) txn(t testing.TB, txn *txntest.Txn) { |
There was a problem hiding this comment.
Is it possible to rename this to something more detailed than txn or txns? Unfortunately I don't have a much better suggestion myself than signAndTestTxn.
There was a problem hiding this comment.
It doesn't sign them. It's a big lie.
I might not object to testTxn, except there is already testTransaction(). testTransaction() does a bunch of tests, but does not actually push it through the evaluator.
There was a problem hiding this comment.
I see, just read the comment above about the unsigned SignedTxn(). Maybe something like prepareAndTestTxn? If not, we can leave it
jannotti
force-pushed
the
txn-eval-testing
branch
from
8b9c2a6
to
fecb795
Compare
|
@tolikzinovyev mind checking how does |
Codecov Report
@@ Coverage Diff @@
## master #2730 +/- ##
==========================================
+ Coverage 47.11% 47.13% +0.01%
==========================================
Files 350 349 -1
Lines 56321 56321
==========================================
+ Hits 26538 26545 +7
+ Misses 26810 26804 -6
+ Partials 2973 2972 -1
Continue to review full report at Codecov.
|
Adds commentary based on context found in algorand#2730.
Adds commentary based on context found in #2730.
This refactors some of the
ledgercode so that it's convenientto write short tests that operate on a fairly complete ledger,
including rewards payouts. Previously, tests used genesis(), but
genesis() build the genesis block internally "by hand" rather
than using MakeGenesisBlock, so it missed some details (like
setting up RewardsState). Presumably, this was because
MakeGenesisBlock was in the
datapackage, and could not beimported. That is the motivation behind moving it, and some
related code, to bookkeeping (where various Genesis related code
already existed).
The txntest packaged is motivated purely by a desire for more
concise tests. It allows for the construction of
transaction.Transaction objects concisely, and we can add all
sort of conveneince routines here that would not make sense in
the production code (turning these into SignedTxns,
SignedTxnWithADs, TransactionGroups, etc).