Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random failures TestWaitAndAddConnectionTimeLongtWindow #2903

Conversation

algonautshant
Copy link
Contributor

Summary

TestWaitAndAddConnectionTimeLongtWindow is randomly failing when the execution of time sensitive statements is separated by more than the expected time gap.

This issue is fixed by replacing the sleep with simulated time passing by changing the recorded time, thus giving the impression that the event happened timeout time ago.

Test Plan

This is a test fix.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #2903 (a11b10b) into master (390edd1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2903      +/-   ##
==========================================
- Coverage   47.11%   47.11%   -0.01%     
==========================================
  Files         349      349              
  Lines       56424    56424              
==========================================
- Hits        26584    26582       -2     
- Misses      26864    26866       +2     
  Partials     2976     2976              
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-1.73%) ⬇️
cmd/tealdbg/debugger.go 72.86% <0.00%> (-1.01%) ⬇️
network/wsNetwork.go 60.90% <0.00%> (-0.19%) ⬇️
ledger/acctupdates.go 62.46% <0.00%> (-0.09%) ⬇️
data/transactions/verify/txn.go 45.08% <0.00%> (ø)
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
network/wsPeer.go 75.48% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 390edd1...a11b10b. Read the comment docs.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please make sure it passes all the automated test.

@tsachiherman tsachiherman merged commit dbab85f into algorand:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants