Allow getting versions for any package. #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2935 +/- ##
==========================================
+ Coverage 47.30% 47.32% +0.01%
==========================================
Files 355 355
Lines 56889 56891 +2
==========================================
+ Hits 26913 26921 +8
+ Misses 26945 26935 -10
- Partials 3031 3035 +4
Continue to review full report at Codecov.
|
onetechnical
requested review from
onetechnical,
algobarb,
algojack,
bricerisingalgorand and
egieseke
and removed request for
algojohnlee
| @@ -67,7 +70,7 @@ var checkCmd = &cobra.Command{ | |||
| if err != nil { | |||
| exitErrorf("Error creating s3 session %s\n", err.Error()) | |||
| } else { | |||
| version, _, err := s3Session.GetLatestUpdateVersion(channel) | |||
| version, _, err := s3Session.GetPackageVersion(channel, packageName, 0) | |||
There was a problem hiding this comment.
looks like you could deprecate GetLatestUpdateVersion with this change.
tsachiherman
suggested changes
Sep 21, 2021
winder
force-pushed
the
will/package-version
branch
from
d632c78
to
90fa8be
Compare
tsachiherman
approved these changes
Oct 26, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
## Summary Add an option to support version checking for arbitrary packages. This would allow us to deploy indexer releases at `algorand-releases/<channel>/indexer-*` ## Test Plan Ran the command and see the correct regex: ``` ~$ updater ver check -c nightly -p indexer Checking for files matching: 'channel/nightly/indexer_nightly_linux-amd64_' in bucket algorand-releases no updates found for channel 'nightly' ```
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an option to support version checking for arbitrary packages. This would allow us to deploy indexer releases at
algorand-releases/<channel>/indexer-*Test Plan
Ran the command and see the correct regex: