Adding clean target to ci-build target #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algojack
requested review from
onetechnical,
egieseke,
bricerisingalgorand and
algobarb
Codecov Report
@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
+ Coverage 47.43% 47.44% +0.01%
==========================================
Files 369 369
Lines 59494 59494
==========================================
+ Hits 28221 28229 +8
+ Misses 27984 27980 -4
+ Partials 3289 3285 -4
Continue to review full report at Codecov.
|
algobarb
reviewed
Nov 16, 2021
| @@ -4,7 +4,7 @@ PKG_DIR = $(SRCPATH)/tmp/node_pkgs/$(OS_TYPE)/$(ARCH) | |||
|
|
|||
| .PHONY: ci-clean ci-setup ci-build | |||
|
|
|||
| ci-clean: | |||
| ci-clean: clean | |||
There was a problem hiding this comment.
What does clean do? Is it like cleanWs() which cleans the Workspace?
There was a problem hiding this comment.
@bricerisingalgorand a little help? I think it deletes temp files created during build command, but i'm not 100% sure.
There was a problem hiding this comment.
There was a problem hiding this comment.
That tries to delete all build/generated files in the current repo
algobarb
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building with Brice, we noticed that
make ci-builddoesn't clean automatically, and we probably want that by default. So we decided to add it.Are there any times we don't want clean included?