-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase machine size to large and use consistent parallelism for circleci nightly testing. #3016
Increase machine size to large and use consistent parallelism for circleci nightly testing. #3016
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3016 +/- ##
==========================================
- Coverage 43.87% 43.87% -0.01%
==========================================
Files 385 385
Lines 86329 86329
==========================================
- Hits 37876 37874 -2
- Misses 42492 42497 +5
+ Partials 5961 5958 -3
Continue to review full report at Codecov.
|
Tsachi's fix worked, so i believe we can cancel this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we need to change all of the machines to large, or that we need parallelism increased to 4, but it works, and to keep 3.1.0 release moving, i approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as what Jack said - not sure we need large machines and parallelism for all, but approving this to be included for 3.1.0 beta release.
…cleci nightly testing. (algorand#3016) For CircleCI testing, increase machine size from medium to large and set parallelism to 4.
Summary
For CircleCI testing, increase machine size from medium to large and set parallelism to 4.
Test Plan
Testing by running nightly builds on the branch.