testing: Disable the participation key refresh on the TestPartitionHalfOffline test #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
approved these changes
Oct 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #3017 +/- ##
==========================================
+ Coverage 43.84% 43.85% +0.01%
==========================================
Files 385 385
Lines 86309 86309
==========================================
+ Hits 37838 37848 +10
+ Misses 42510 42504 -6
+ Partials 5961 5957 -4
Continue to review full report at Codecov.
|
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
… branch. (algorand#3017) ## Summary Disable the participation key refresh on the TestPartitionHalfOffline test. The test was failing with the following threads running: ``` algod(20739) : github.com/algorand/go-algorand/agreement.(*asyncPseudonode).loadRoundParticipationKeys(0xc0033dad20, 0x2, 0xc0039c8180, 0xc000530000, 0xc000dcb0d0) ``` ``` algod(20739) : github.com/algorand/go-algorand/data/account.PersistedParticipation.DeleteOldKeys(0x92c6b21bbd8fefac, 0xed2d99ce769768ea, 0xac85a3b9466cead1, 0xc32937d7e4c532f9, 0xc000043260, 0xc0002b04b0, 0x0, 0x2dc6c0, 0x2710, 0xc0001892c0, ...) ``` ``` algod(20739) : github.com/algorand/go-algorand/data.(*AccountManager).AddParticipation(0xc0001191a0, 0xd175b5d042fa1c39, 0x2140fe15c6a19653, 0xc66f7b9c58cf5ed1, 0x107d657815b44d49, 0xc0037a4d20, 0xc0002b0690, 0x0, 0x2dc6c0, 0x2710, ...) ``` By avoiding the participation key reload ( which isn't needed for this test ), I'm hoping to avoid the issue. ## Test Plan This is a test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable the participation key refresh on the TestPartitionHalfOffline test. The test was failing with the following threads running:
By avoiding the participation key reload ( which isn't needed for this test ), I'm hoping to avoid the issue.
Test Plan
This is a test.