Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildpulse #3051

Merged
merged 15 commits into from
Oct 21, 2021
Merged

Add buildpulse #3051

merged 15 commits into from
Oct 21, 2021

Conversation

cce
Copy link
Contributor

@cce cce commented Oct 13, 2021

Summary

This adds buildpulse integration by downloading their reporter for each platform we run tests on, and comparing it to known checksums.

Test Plan

CI changes only

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #3051 (98500a1) into master (c2054e5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3051      +/-   ##
==========================================
- Coverage   43.68%   43.65%   -0.04%     
==========================================
  Files         390      390              
  Lines       86681    86681              
==========================================
- Hits        37868    37840      -28     
- Misses      42796    42818      +22     
- Partials     6017     6023       +6     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
network/wsPeer.go 69.86% <0.00%> (-2.94%) ⬇️
ledger/blockqueue.go 81.03% <0.00%> (-2.88%) ⬇️
util/metrics/gauge.go 68.00% <0.00%> (-2.67%) ⬇️
util/metrics/counter.go 78.57% <0.00%> (-2.39%) ⬇️
data/abi/abi_type.go 92.03% <0.00%> (-1.00%) ⬇️
catchup/service.go 70.35% <0.00%> (-0.76%) ⬇️
ledger/internal/eval.go 69.94% <0.00%> (-0.27%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2054e5...98500a1. Read the comment docs.

@cce
Copy link
Contributor Author

cce commented Oct 18, 2021

@onetechnical @algobarb @algojack this is ready for review/merge

Copy link
Contributor

@algojack algojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@algojack
Copy link
Contributor

@onetechnical
Copy link
Contributor

Are we signing up for buildpulse @onetechnical ?https://github.com/marketplace/buildpulse/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW40NzM5#pricing-and-setup

Yes. Chris has been POCing it to see if we can get better test result evaluation.

@algojohnlee algojohnlee merged commit 57a3306 into master Oct 21, 2021
@cce cce deleted the buildpulse branch October 21, 2021 17:48
cce added a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
This adds buildpulse integration using their orb.
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants