Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed off-by-one error in the assembler's typeDig() #3056

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

algoidurovic
Copy link
Contributor

Summary

This type checking bug was discovered while using the TEAL debugger. A correction to typedDig() + improved unit tests were added.

Test Plan

Added new unit test and corrected existing one.

Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Glad to see the extra test. I'll merge once CI compleetes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #3056 (430552f) into master (3572e1f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3056      +/-   ##
==========================================
+ Coverage   43.65%   43.67%   +0.01%     
==========================================
  Files         391      391              
  Lines       86792    86792              
==========================================
+ Hits        37893    37906      +13     
+ Misses      42872    42861      -11     
+ Partials     6027     6025       -2     
Impacted Files Coverage Δ
data/transactions/logic/assembler.go 79.26% <100.00%> (ø)
agreement/cryptoVerifier.go 75.73% <0.00%> (-2.21%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
ledger/acctupdates.go 66.53% <0.00%> (+0.09%) ⬆️
network/wsNetwork.go 63.14% <0.00%> (+0.18%) ⬆️
network/wsPeer.go 73.83% <0.00%> (+0.25%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
txnsync/encodedgroupsmarshalers.go 100.00% <0.00%> (+1.12%) ⬆️
ledger/blockqueue.go 83.90% <0.00%> (+1.72%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3572e1f...430552f. Read the comment docs.

@jannotti jannotti merged commit 754276b into algorand:master Oct 14, 2021
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants