Add ABI support to goal #3088

ahangsu · 2021-10-18T15:47:00Z

Summary

Implement JSON unmarshal to golang values on ABI encoding
Implement a method sub-command to accept method signature and application args
Add a way to view the return value of an app call.

Addressing #2803

Test Plan

Test unmarshal JSON values from command line to ABI encoding

cmd/goal/application.go

…lient

cmd/goal/application.go

data/abi/abi_type.go

jasonpaulos

Looking good, just a nit

test/scripts/e2e_subs/e2e-app-abi-arg.sh

test/scripts/e2e_subs/e2e-app-abi-add.sh

cmd/goal/application.go

data/abi/abi_json.go

data/abi/abi_json_test.go

cmd/goal/application.go

tzaffi · 2021-11-09T20:59:56Z

cmd/goal/application.go

+var methodAppCmd = &cobra.Command{
+	Use:   "method",
+	Short: "Invoke a method",
+	Long:  `Invoke a method in an App (stateful contract) with an application call transaction`,


I'm not proposing any changes here, but view this as a learning opportunity for me about Algorand's conventions. Cleary the convention in the file is for this field to use raw string literals. I guess that makes sense, because in theory the Long description could span several lines. However, none of the descriptions in this file seem to utilize any of the string literal's special features. Any thoughts? You can also totally ignore.

I don't have specific thoughts or idea about it, just following the previous conventions. I just noticed the nearest editing for adding method/updating description is 16 months ago... and I suppose they might want to do something with string literal.

ahangsu added 30 commits August 25, 2021 14:42

add abi encoding

42a56b4

accord with go-algorand code format

ab9104e

minor modification

80c1975

add partition test

f5c0f21

resolve review, need more testcase rewrite

bdd3c10

move from cmd/goal to data, resolve review

3f6d738

rewrite is-dynamic, dynamic array

badcc28

update dynamic array 0 element support, test needed

a613273

minor

bf4e035

minor

1e8f62b

minor

c570d80

add more testcase for abi encode/decode

500ad45

update comments in encoding test

7d563f1

minor

2f3fe42

attempt to split abi.go into 2 files

c87719c

separate abi files to smaller files

2dd6028

resolve reviews, work on random gen tuple value encode/decode

93abb82

add random tuple test

c23cad3

remove math-rand, use crypto-rand

ba68ea9

minor

438ccd2

minor

825e98d

some change requested from community

43ff514

fix for 1 corner case

c757de5

resolve review comments

515ef05

resolve review comments

da39a1f

minor

1ce16fd

minor

023e10d

update encode slot capacity

1aaf43d

minor

5b60ae6

resolve reviews

74f7550

jannotti reviewed Nov 9, 2021

View reviewed changes

cmd/goal/application.go Outdated Show resolved Hide resolved

cmd/goal/application.go Outdated Show resolved Hide resolved

cmd/goal/application.go Outdated Show resolved Hide resolved

cmd/goal/application.go Outdated Show resolved Hide resolved

ahangsu added 3 commits November 9, 2021 11:10

resolve review partly

2d06d9f

resolve review on code reformatting

3267ff1

resolve review on code reformatting, use code chunk for datadir and c…

435cca9

…lient

github-actions bot reviewed Nov 9, 2021

View reviewed changes

cmd/goal/application.go Outdated Show resolved Hide resolved

ahangsu added 2 commits November 9, 2021 11:53

go fmt

d1e8ead

export tuple type maker

fac68f3

ahangsu commented Nov 9, 2021

View reviewed changes

data/abi/abi_type.go Show resolved Hide resolved

jasonpaulos previously approved these changes Nov 9, 2021

View reviewed changes

test/scripts/e2e_subs/e2e-app-abi-arg.sh Outdated Show resolved Hide resolved

test/scripts/e2e_subs/e2e-app-abi-add.sh Outdated Show resolved Hide resolved

update comments in e2e test

78ed7ac

ahangsu dismissed jasonpaulos’s stale review via 78ed7ac November 9, 2021 17:35

jasonpaulos previously approved these changes Nov 9, 2021

View reviewed changes

jannotti reviewed Nov 9, 2021

View reviewed changes

cmd/goal/application.go Outdated Show resolved Hide resolved

update filter empty string

89f3f3a

ahangsu dismissed jasonpaulos’s stale review via 89f3f3a November 9, 2021 18:36

jannotti reviewed Nov 9, 2021

View reviewed changes

data/abi/abi_json.go Outdated Show resolved Hide resolved

data/abi/abi_json_test.go Show resolved Hide resolved

resolve issues with JSON abi

34fc96a

tzaffi reviewed Nov 9, 2021

View reviewed changes

cmd/goal/application.go Outdated Show resolved Hide resolved

minor

310180d

jannotti approved these changes Nov 9, 2021

View reviewed changes

tzaffi reviewed Nov 9, 2021

View reviewed changes

jasonpaulos mentioned this pull request Nov 9, 2021

ABI Interaction integration tests with app calls algorand/algorand-sdk-testing#148

Merged

1 task

jannotti merged commit d3bbe62 into master Nov 9, 2021

ahangsu deleted the feature/goal-abi-support branch November 9, 2021 23:09

jasonpaulos mentioned this pull request Nov 10, 2021

Support foreign objects as ABI arguments in goal app method #3205

Closed

ahangsu mentioned this pull request Nov 10, 2021

goal abi method outfile checking #3204

Merged

This was referenced Nov 17, 2021

Support unsigned transactions as ABI arguments in goal app method #3226

Closed

Fix OnCompletion flag for goal app method #3228

Merged

egieseke mentioned this pull request Nov 23, 2021

go-algorand 3.2.0-beta #3231

Merged

algobarb mentioned this pull request Dec 7, 2021

go-algorand 3.2.1-stable #3279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ABI support to goal #3088

Add ABI support to goal #3088

ahangsu commented Oct 18, 2021 •

edited

Loading

jasonpaulos left a comment

tzaffi Nov 9, 2021

ahangsu Nov 9, 2021

Add ABI support to goal #3088

Add ABI support to goal #3088

Conversation

ahangsu commented Oct 18, 2021 • edited Loading

Summary

Test Plan

jasonpaulos left a comment

Choose a reason for hiding this comment

tzaffi Nov 9, 2021

Choose a reason for hiding this comment

ahangsu Nov 9, 2021

Choose a reason for hiding this comment

ahangsu commented Oct 18, 2021 •

edited

Loading