Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-algorand v3.1.2-beta #3103

Merged
merged 2 commits into from
Oct 20, 2021
Merged

go-algorand v3.1.2-beta #3103

merged 2 commits into from
Oct 20, 2021

Conversation

onetechnical
Copy link
Contributor

Network

  • Bug Fix: txnsync: implement missing bridge between txnsync and classic transaction messages

tsachiherman and others added 2 commits October 20, 2021 08:54
@tsachiherman @onetechnical
txnsync: implement missing bridge between txnsync and classic transac…
facfb03 
…tion messages (#3102)

Summary
This PR adds the missing bridge between the txnsync and the classic transaction relaying:
when a transaction message arrive and being added to the transaction pool, we need to attempt to
relay these messages right away using the classic transaction messages. That would allow relays to
be compatible with both 2.1 and 3.0 nodes.

Test Plan
e2e test was added.
@onetechnical
Bump build number
2eb56bb
@onetechnical onetechnical added this to the Sprint 2 - HF Q4 milestone Oct 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #3103 (2eb56bb) into rel/beta (dbd0ec9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rel/beta    #3103      +/-   ##
============================================
- Coverage     43.82%   43.82%   -0.01%     
============================================
  Files           385      385              
  Lines         86319    86323       +4     
============================================
- Hits          37831    37830       -1     
- Misses        42527    42532       +5     
  Partials       5961     5961
Impacted Files Coverage Δ
data/txHandler.go 9.13% <0.00%> (-0.17%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
network/wsNetwork.go 62.58% <0.00%> (-0.19%) ⬇️
ledger/acctupdates.go 63.02% <0.00%> (-0.17%) ⬇️
network/wsPeer.go 73.31% <0.00%> (ø)
catchup/service.go 70.12% <0.00%> (+0.77%) ⬆️
data/transactions/verify/txn.go 44.29% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd0ec9...2eb56bb. Read the comment docs.

@algojohnlee algojohnlee merged commit 53cf013 into rel/beta Oct 20, 2021
@algojohnlee algojohnlee deleted the rel/beta-3.1.2 branch October 20, 2021 16:22
@algojohnlee algojohnlee restored the rel/beta-3.1.2 branch October 20, 2021 16:22
@algobarb algobarb deleted the rel/beta-3.1.2 branch January 5, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsachiherman tsachiherman tsachiherman approved these changes

@algojack algojack Awaiting requested review from algojack

@bricerisingalgorand bricerisingalgorand Awaiting requested review from bricerisingalgorand

@egieseke egieseke Awaiting requested review from egieseke

Assignees
No one assigned
Labels
Team Hyper Flow unplanned
Projects
None yet
Milestone
Sprint 2 - HF Q4
Development

Successfully merging this pull request may close these issues.
4 participants
@onetechnical @codecov-commenter @tsachiherman @algojohnlee