networking: update the websocket library #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3131 +/- ##
==========================================
- Coverage 43.70% 43.69% -0.01%
==========================================
Files 390 390
Lines 86689 86689
==========================================
- Hits 37887 37879 -8
- Misses 42780 42784 +4
- Partials 6022 6026 +4
Continue to review full report at Codecov.
|
ghost
approved these changes
Oct 22, 2021
onetechnical
pushed a commit
that referenced
this pull request
Oct 25, 2021
## Summary The previous web socket version was not flushing the write buffer when writing a Close control message. As a result, we ended up disconnection the connection on one side correctly, while having it in a zombie state on the other side. ## Test Plan Use existing tests. The `TestSlowPeerDisconnection` was already observing the issue being resolved.
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
The previous web socket version was not flushing the write buffer when writing a Close control message. As a result, we ended up disconnection the connection on one side correctly, while having it in a zombie state on the other side. Use existing tests. The `TestSlowPeerDisconnection` was already observing the issue being resolved.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous web socket version was not flushing the write buffer when writing a Close control message.
As a result, we ended up disconnection the connection on one side correctly, while having it in a zombie state on the other side.
Test Plan
Use existing tests. The
TestSlowPeerDisconnectionwas already observing the issue being resolved.