-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: benchmark assemble / transaction pool's uses of recomputeBlockEvaluator #3138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3138 +/- ##
==========================================
- Coverage 55.25% 55.23% -0.02%
==========================================
Files 398 398
Lines 50297 50297
==========================================
- Hits 27793 27784 -9
- Misses 20171 20180 +9
Partials 2333 2333
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little dead code to cleanup, otherwise looks reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Summary
First draft at attempting to profile CPU and benchmark calling recomputeBlockEvaluator on large pool & block sizes to examine performance bottlenecks updating the transaction pool when a new block arrives.
I was running with GOGC=off to try and declutter the profiles, especially when b.N > 1.
Test Plan
Adds a test.