ledger refactoring: Ordered resource deltas - part 1 #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MergeInMatchingAccounts requires addresses per resource but storing addresses there makes the code much slower. Lets see if MergeInMatchingAccounts can be eliminated altogether on the schema switch
Codecov Report
@@ Coverage Diff @@
## feature/unlimited-assets #3292 +/- ##
=============================================================
- Coverage 46.92% 36.24% -10.69%
=============================================================
Files 371 369 -2
Lines 61511 61603 +92
=============================================================
- Hits 28865 22327 -6538
- Misses 29245 36320 +7075
+ Partials 3401 2956 -445
Continue to review full report at Codecov.
|
algorandskiy
changed the title
tsachiherman
suggested changes
Dec 10, 2021
tsachiherman
approved these changes
Dec 10, 2021
tsachiherman
pushed a commit
that referenced
this pull request
Dec 10, 2021
## Summary This is follow up PR for #3292 ## Test Plan This is mostly existing tests modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MergeInMatchingAccounts requires addresses per resource but storing addresses there makes the code much slower.
Lets see if MergeInMatchingAccounts can be eliminated altogether on the schema switch.
Test Plan
Added new test for triggering missed base account data in StateDelta for some application resources modification.