-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give more time for e2e_basic_start_stop's verify_none_running #3385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3385 +/- ##
==========================================
- Coverage 47.65% 47.63% -0.02%
==========================================
Files 370 370
Lines 59804 59804
==========================================
- Hits 28498 28490 -8
- Misses 28001 28007 +6
- Partials 3305 3307 +2
Continue to review full report at Codecov.
|
The CircleCi tests still seem to be failing? Do you think it would still help rel/nightly? |
I'm assuming there's some timeout that is high enough to handle these occasional cases where algod needs a little more time to quit. So hopefully the last commit (which raises it to 20s) should be enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if it was the last commit that made it pass, but I don't think this will hurt to try it on our flaky tests
I think that we have a bug in algod which prevents it from shutting down when requested. While this PR is not wrong on it's own, I think that figuring out the slowness during the shutdown would be a good thing to accomplish. ( which might also resolve this issue ). i.e. the following is one step toward achieving this : |
Summary
This test has been failing more often in recent nightly jobs. Giving it more time to wait for algod to shut down should help.
Test Plan
Modifies existing test.