Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: rollback changes to ParticipationExpirationTest #3611

Conversation

tsachiherman
Copy link
Contributor

Summary

The state proof branch contained a change to testExpirationAccounts, changing the partKeyValidityPeriod from 10 to 150. This increase the duration of the test substantially, and (apparently) also causing the test to fail.

This PR rolls back that change.

Test Plan

This is a test.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #3611 (3b71974) into master (71e39cd) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3611      +/-   ##
==========================================
+ Coverage   48.06%   48.07%   +0.01%     
==========================================
  Files         381      381              
  Lines       62074    62074              
==========================================
+ Hits        29836    29844       +8     
+ Misses      28817    28804      -13     
- Partials     3421     3426       +5     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
network/requestTracker.go 70.68% <0.00%> (-0.44%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
catchup/service.go 69.38% <0.00%> (ø)
network/wsPeer.go 68.61% <0.00%> (+0.55%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e39cd...3b71974. Read the comment docs.

@tsachiherman tsachiherman merged commit 53b157b into algorand:master Feb 11, 2022
@tsachiherman tsachiherman deleted the tsachi/rollbackParticipationExpirationTest branch February 11, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants