-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goal node create improvements #3639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3639 +/- ##
==========================================
+ Coverage 48.06% 49.82% +1.75%
==========================================
Files 381 382 +1
Lines 62080 64264 +2184
==========================================
+ Hits 29841 32019 +2178
- Misses 28818 28823 +5
- Partials 3421 3422 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me
@tsachiherman followed your suggestion and embedded genesis files. |
b48a24b
to
7035846
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1686 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Summary
--full-config
options allows saving config file with all options, not only non-default.Test Plan
Tested manually