Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: add StateProofID to AccountData.ClearOnlineState() #3643

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented Feb 16, 2022

Summary

Clear out AccountData.StateProofID when ClearOnlineState() is called, by resetExpiredOnlineAccountsParticipationKeys (as part of #2924)

Test Plan

Updated TestExpiredAccountGeneration to generate random online account data, so that it fails without this change.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I do agree with this change, we can't implement it like this.

@tsachiherman
Copy link
Contributor

I think that this should be implemented with a future flag. Then, we'll be able to merge it to master.

@pzbitskiy
Copy link
Contributor

I think we need a hotfix into betanet

@id-ms
Copy link
Contributor

id-ms commented Feb 17, 2022

I would suggest we move those fields into a new struct and clean the entire struct.
clearing individual fields will lead to errors (as we have seen)

@tsachiherman tsachiherman dismissed their stale review February 17, 2022 18:08

confirmed we're going to hot fix.

@cce
Copy link
Contributor Author

cce commented Feb 17, 2022

@algoidan we've already moved the fields into a VotingData{} struct on the feature/unlimited-assets branch, and I just made the change you suggested to clear the entire struct here: a5e867f

@tsachiherman tsachiherman merged commit 468d34b into algorand:master Feb 17, 2022
@onetechnical onetechnical changed the title add StateProofID to AccountData.ClearOnlineState() ledger: add StateProofID to AccountData.ClearOnlineState() Feb 17, 2022
@cce cce deleted the ClearOnlineState-StateProofID branch February 17, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants