-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger: add StateProofID to AccountData.ClearOnlineState() #3643
ledger: add StateProofID to AccountData.ClearOnlineState() #3643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while I do agree with this change, we can't implement it like this.
I think that this should be implemented with a future flag. Then, we'll be able to merge it to master. |
I think we need a hotfix into betanet |
I would suggest we move those fields into a new struct and clean the entire struct. |
@algoidan we've already moved the fields into a VotingData{} struct on the feature/unlimited-assets branch, and I just made the change you suggested to clear the entire struct here: a5e867f |
Summary
Clear out AccountData.StateProofID when ClearOnlineState() is called, by resetExpiredOnlineAccountsParticipationKeys (as part of #2924)
Test Plan
Updated TestExpiredAccountGeneration to generate random online account data, so that it fails without this change.