Algod: Compcert signature version #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/stateproofs #3665 +/- ##
=======================================================
- Coverage 48.10% 48.06% -0.05%
=======================================================
Files 381 381
Lines 62080 62086 +6
=======================================================
- Hits 29864 29841 -23
- Misses 28800 28823 +23
- Partials 3416 3422 +6
Continue to review full report at Codecov.
|
id-ms
reviewed
Feb 22, 2022
id-ms
approved these changes
Feb 23, 2022
algonathan
changed the title
id-ms
pushed a commit
that referenced
this pull request
Feb 27, 2022
* adding version check for falcon signatures * go.mod tidy * removed from merklesig Verify func: version inspection * using in32 in compcert * added unit test to validation of falcon sig version * unit test to inspect correct version of signature * refactor, no need to hold a whole verify in order to verify sig version * fix: untidy gomod * repositioned error var * fix: using assert.ErrorIs instead of Equals * renamed func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan