Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: split msgpack API type AccountResourceModel into two #3679

Conversation

cce
Copy link
Contributor

@cce cce commented Feb 23, 2022

Summary

Address code review feedback in #3652 (comment)

Also updates API swagger descriptions as per #3652 (comment)

Test Plan

Existing tests should pass

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #3679 (b737a8f) into feature/unlimited-assets (305a0b0) will increase coverage by 1.69%.
The diff coverage is 71.50%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/unlimited-assets    #3679      +/-   ##
============================================================
+ Coverage                     47.81%   49.51%   +1.69%     
============================================================
  Files                           375      389      +14     
  Lines                         63955    68382    +4427     
============================================================
+ Hits                          30583    33858    +3275     
- Misses                        29727    30793    +1066     
- Partials                       3645     3731      +86     
Impacted Files Coverage Δ
agreement/abstractions.go 50.00% <ø> (ø)
cmd/goal/application.go 11.16% <0.00%> (-0.02%) ⬇️
cmd/goal/asset.go 16.66% <0.00%> (ø)
cmd/goal/interact.go 3.35% <0.00%> (-0.01%) ⬇️
cmd/tealdbg/cdtSession.go 67.87% <0.00%> (ø)
cmd/tealdbg/debugger.go 71.42% <0.00%> (-1.44%) ⬇️
compactcert/db.go 73.68% <ø> (ø)
compactcert/worker.go 90.00% <ø> (ø)
config/localTemplate.go 42.85% <0.00%> (-7.15%) ⬇️
crypto/digest.go 0.00% <0.00%> (ø)
... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d951a88...b737a8f. Read the comment docs.

algorandskiy
algorandskiy previously approved these changes Feb 23, 2022
daemon/algod/api/algod.oas3.yml Show resolved Hide resolved
daemon/algod/api/spec/v2/model.go Outdated Show resolved Hide resolved
jasonpaulos
jasonpaulos previously approved these changes Feb 24, 2022
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making the changes

… feature/unlimited-assets-api-split-accountresource
@cce cce merged commit 6278dc1 into algorand:feature/unlimited-assets Feb 25, 2022
@cce cce deleted the feature/unlimited-assets-api-split-accountresource branch February 25, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants