Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: fix check for record.AppParams in AccountApplicationInformation #3707

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented Mar 2, 2022

Summary

Follow-on to #3702, the copy-pasted code in AccountApplicationInformation was checking the wrong value before returning AppParams.

@cce cce added the Bug-Fix label Mar 2, 2022
@tsachiherman
Copy link
Contributor

any chance you could provide a unit test for this one ? maybe extend an existing unit test to cover this one as well ?

@cce
Copy link
Contributor Author

cce commented Mar 2, 2022

Yes, sure ... my unit tests created multiple apps AND assets for accounts, but not just assets or just apps, which is why it wasn't caught by the existing tests.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #3707 (4797e2e) into master (e1ae888) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3707      +/-   ##
==========================================
- Coverage   49.58%   49.58%   -0.01%     
==========================================
  Files         390      390              
  Lines       68551    68551              
==========================================
- Hits        33992    33990       -2     
+ Misses      30826    30825       -1     
- Partials     3733     3736       +3     
Impacted Files Coverage Δ
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
network/wsPeer.go 68.05% <0.00%> (-2.78%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
data/transactions/verify/txn.go 45.02% <0.00%> (ø)
network/wsNetwork.go 62.99% <0.00%> (+0.19%) ⬆️
catchup/service.go 69.38% <0.00%> (+0.74%) ⬆️
cmd/tealdbg/debugger.go 72.41% <0.00%> (+0.98%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ae888...4797e2e. Read the comment docs.

@tsachiherman tsachiherman merged commit 09b6c38 into algorand:master Mar 3, 2022
@cce cce deleted the fix-rest-accountappinfo-record branch March 3, 2022 02:25
@egieseke egieseke mentioned this pull request Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants