Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agreement: Add warning when decoding proposal of an unsupported consensus version #3730

Merged
merged 6 commits into from
Mar 14, 2022
Merged

Agreement: Add warning when decoding proposal of an unsupported consensus version #3730

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e38f9cd
add error msg
nicholasguo Mar 8, 2022
49d92ce
lint
nicholasguo Mar 9, 2022
0dd1649
lint
nicholasguo Mar 9, 2022
09e3c33
change to only have change in demux
nicholasguo Mar 10, 2022
9513bd9
tweak
nicholasguo Mar 14, 2022
3064162
update
nicholasguo Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion agreement/demux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"fmt"
"time"

"github.com/algorand/go-algorand/config"
"github.com/algorand/go-algorand/logging"
"github.com/algorand/go-algorand/logging/logspec"
"github.com/algorand/go-algorand/protocol"
Expand Down Expand Up @@ -122,7 +123,15 @@ func (d *demux) tokenizeMessages(ctx context.Context, net Network, tag protocol.

o, err := tokenize(raw.Data)
if err != nil {
d.log.Warnf("disconnecting from peer: error decoding message tagged %v: %v", tag, err)
warnMsg := fmt.Sprintf("disconnecting from peer: error decoding message tagged %v: %v", tag, err)
// check protocol version
cv, err := d.ledger.ConsensusVersion(d.ledger.NextRound())
if err == nil {
if _, ok := config.Consensus[cv]; !ok {
warnMsg = fmt.Sprintf("received proposal message was ignored. The node binary doesn't support the next network consensus (%v) and would no longer be able to process agreement messages", cv)
}
}
d.log.Warn(warnMsg)
net.Disconnect(raw.MessageHandle)
d.UpdateEventsQueue(eventQueueTokenizing[tag], 0)
continue
Expand Down