REST API: use ErrorResponse instead of AccountsErrorResponse #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
approved these changes
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #3737 +/- ##
==========================================
- Coverage 49.57% 49.56% -0.01%
==========================================
Files 392 392
Lines 68590 68592 +2
==========================================
- Hits 34006 34001 -5
- Misses 30845 30851 +6
- Partials 3739 3740 +1
Continue to review full report at Codecov.
|
winder
approved these changes
Mar 9, 2022
jannotti
pushed a commit
to jannotti/go-algorand
that referenced
this pull request
Mar 13, 2022
## Summary Complementing algorand/indexer#916 this merges the AccountsErrorResponse fields into the "data" object in ErrorResponse, so SDKs do not to have to distinguish between different error response types. ## Test Plan Update existing tests checking the old AccountsErrorResponse fields.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complementing algorand/indexer#916 this merges the AccountsErrorResponse fields into the "data" object in ErrorResponse, so SDKs do not to have to distinguish between different error response types.
Test Plan
Update existing tests checking the old AccountsErrorResponse fields.