Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger refactoring: test 6M assets/apps per account #3739

Merged
merged 71 commits into from
Mar 11, 2022
Merged

ledger refactoring: test 6M assets/apps per account #3739

merged 71 commits into from
Mar 11, 2022

Conversation

algonautshant
Copy link
Contributor

@algonautshant algonautshant commented Mar 10, 2022 •
edited by tsachiherman
Loading

Solution

ledger refactoring: test 6M assets/apps per account
resolves https://github.com/algorand/go-algorand-internal/issues/1857

Testing

This is a test

@algonautshant
initial draft
88f1332
@algonautshant
cleanup, add assets
41d1d43
@algonautshant
fixes and asset distribution
bdb50f9
@algonautshant
fixes
702fabc
@algonautshant
fix error reporting
30e1387
@algonautshant
txn grouping (broken)
0f49e01
@algonautshant
fix ballance requirements
3c68184
@algonautshant
sign txns without kmd
170e33e
@algonautshant
group transactions
ca5762f
@algonautshant
fix
dabfa9c
@algonautshant
tiny fixes
fe9f1f2
@algonautshant
fix
4039c2c
@algonautshant
add scenario 2
8d6cf4b
@algonautshant
allow MaxAccountsAPIResults 7m
2dbcb55
@algonautshant
tiny fixes
8bf3488
@algonautshant
investigate panic at the end of shutdown
f4e160b
@algonautshant
investigate panic at the end of shutdown
b245c0a
@algonautshant
cleanup
452a1cc
@algonautshant
algod shutdown panic repro
ede05ab
@algonautshant
algod shutdown panic repro
73a4cb2
@algonautshant
algod shutdown panic repro
8990e10
@algonautshant
create apps
0ddae64
@algonautshant
check the created app
dcb6031
@algonautshant
parallel app verification
8b171e5
@algonautshant
skip on errors
475621d
@algonautshant
app create/optin/call
fcdaa04
@algonautshant
raise balance for the apps
b69a021
@algonautshant
don't retry on error txn already in ledger
74f0954
@algonautshant
enhance error tolerance from the network
28f1385
@algonautshant
fix bug
1c0d50f
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #3739 (b12bb7e) into master (9b13756) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3739   +/-   ##
=======================================
  Coverage   49.66%   49.66%           
=======================================
  Files         392      392           
  Lines       68588    68590    +2     
=======================================
+ Hits        34065    34068    +3     
- Misses      30780    30781    +1     
+ Partials     3743     3741    -2
Impacted Files Coverage Δ
node/node.go 23.26% <0.00%> (-0.08%) ⬇️
catchup/service.go 68.64% <0.00%> (-1.49%) ⬇️
cmd/tealdbg/debugger.go 71.42% <0.00%> (-0.99%) ⬇️
ledger/acctupdates.go 68.42% <0.00%> (-0.67%) ⬇️
network/requestTracker.go 70.68% <0.00%> (-0.44%) ⬇️
network/wsNetwork.go 62.99% <0.00%> (+0.19%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
network/wsPeer.go 68.88% <0.00%> (+3.05%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b13756...b12bb7e. Read the comment docs.

@algonautshant algonautshant changed the title ledger refactoring: test 6M assets/apps per account Tests: ledger refactoring: test 6M assets/apps per account Mar 10, 2022
@algonautshant algonautshant changed the title Tests: ledger refactoring: test 6M assets/apps per account New Feature: ledger refactoring: test 6M assets/apps per account Mar 10, 2022
@algobarb algobarb changed the title New Feature: ledger refactoring: test 6M assets/apps per account ledger refactoring: test 6M assets/apps per account Mar 10, 2022
tsachiherman
tsachiherman suggested changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to the previous comments:
In test, we shouldn't use fmt.Printf. Instead, we should be using t.Log, or even better, logging.TestingLog.

@tsachiherman tsachiherman merged commit f8a869b into algorand:master Mar 11, 2022
jannotti pushed a commit to jannotti/go-algorand that referenced this pull request Mar 13, 2022
@algonautshant @jannotti
ledger refactoring: test 6M assets/apps per account (algorand#3739)
fa4a34d 
## Solution 

ledger refactoring: test 6M assets/apps per account
resolves algorand/go-algorand-internal#1857


## Testing

This is a test
@algojack algojack mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsachiherman tsachiherman tsachiherman approved these changes

@cce cce Awaiting requested review from cce

Assignees

@algonautshant algonautshant

Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@algonautshant @codecov-commenter @tsachiherman @algobarb @cce