Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algod: Compcert msg into struct #3742

Merged
merged 34 commits into from
Mar 14, 2022

Conversation

algonathan
Copy link
Contributor

Summary

Test Plan

compactcert/signer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@id-ms id-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks pretty good.
There are few things I think we should take into consideration

compactcert/builder.go Outdated Show resolved Hide resolved
compactcert/signer.go Outdated Show resolved Hide resolved
crypto/compactcert/structs.go Outdated Show resolved Hide resolved
crypto/falconWrapper_test.go Outdated Show resolved Hide resolved
crypto/compactcert/structs.go Outdated Show resolved Hide resolved
crypto/compactcert/structs.go Outdated Show resolved Hide resolved
@id-ms id-ms changed the title Algorand: Compcert msg into struct Algod: Compcert msg into struct Mar 13, 2022
data/stateproof/message.go Outdated Show resolved Hide resolved
data/stateproof/message.go Outdated Show resolved Hide resolved
data/stateproof/message.go Show resolved Hide resolved
compactcert/builder.go Outdated Show resolved Hide resolved
compactcert/signer.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #3742 (6c00224) into feature/stateproofs (f9a8d27) will increase coverage by 0.00%.
The diff coverage is 53.17%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feature/stateproofs    #3742   +/-   ##
====================================================
  Coverage                49.61%   49.61%           
====================================================
  Files                      391      393    +2     
  Lines                    68529    68621   +92     
====================================================
+ Hits                     33998    34047   +49     
- Misses                   30787    30826   +39     
- Partials                  3744     3748    +4     
Impacted Files Coverage Δ
compactcert/worker.go 90.00% <ø> (ø)
crypto/compactcert/common.go 75.00% <ø> (ø)
daemon/algod/api/server/v1/handlers/handlers.go 0.62% <0.00%> (ø)
data/stateproof/message.go 0.00% <0.00%> (ø)
data/transactions/compactcert.go 23.07% <0.00%> (ø)
ledger/internal/eval.go 66.44% <ø> (ø)
ledger/ledger.go 59.66% <ø> (ø)
data/stateproof/msgp_gen.go 42.18% <42.18%> (ø)
compactcert/signer.go 54.54% <58.33%> (+1.60%) ⬆️
data/transactions/msgp_gen.go 40.39% <58.33%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a8d27...6c00224. Read the comment docs.

@id-ms id-ms merged commit abf37ea into algorand:feature/stateproofs Mar 14, 2022
@algonathan algonathan deleted the compcert-msg branch May 29, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants