Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: improve 6M asset testing performance #3749

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

tsachiherman
Copy link
Contributor

Summary

This PR replaces the usage of the LibGoal with the direct RestClient. The change could have performance implications when running against large sets of data.

Test Plan

This is a test.

@tsachiherman tsachiherman self-assigned this Mar 11, 2022
@tsachiherman tsachiherman changed the title improve 6M asset testing performance testing: improve 6M asset testing performance Mar 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #3749 (0b5be07) into master (f8a869b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3749   +/-   ##
=======================================
  Coverage   49.75%   49.75%           
=======================================
  Files         392      392           
  Lines       68746    68746           
=======================================
+ Hits        34204    34205    +1     
- Misses      30776    30778    +2     
+ Partials     3766     3763    -3     
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 68.33% <0.00%> (-0.28%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
ledger/acctupdates.go 68.42% <0.00%> (ø)
catchup/service.go 69.38% <0.00%> (+0.74%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a869b...0b5be07. Read the comment docs.

Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tsachiherman tsachiherman merged commit 842e69d into algorand:master Mar 11, 2022
@tsachiherman tsachiherman deleted the tsachi/accountstesting branch March 11, 2022 11:29
jannotti pushed a commit to jannotti/go-algorand that referenced this pull request Mar 13, 2022
Summary
This PR replaces the usage of the LibGoal with the direct RestClient. The change could have performance implications when running against large sets of data.

Test Plan
This is a test.
@algojack algojack mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants