Ledger: Refactor online totals #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
@@ Coverage Diff @@
## master #3770 +/- ##
==========================================
- Coverage 49.68% 49.66% -0.02%
==========================================
Files 392 392
Lines 68588 68585 -3
==========================================
- Hits 34076 34063 -13
- Misses 30766 30779 +13
+ Partials 3746 3743 -3
Continue to review full report at Codecov.
|
|
Please don't forget to elimimate account update Totals - I think that now it's only used by tests. |
ghost
marked this pull request as ready for review
tsachiherman
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Changes here looks great, but I'd like @algorandskiy to be familiar with these changes as well before merging this in.
algorandskiy
approved these changes
Mar 18, 2022
tsachiherman
pushed a commit
that referenced
this pull request
Mar 19, 2022
This was referenced Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing Ledger.OnlineTotals is going ( at the end of the 320 project ), be using the onlineAccountsTracker to get its information from.
But unlike the existing l.accts.Totals(rnd) call, it won't get the totals, but only the amount of online totals ( i.e. basics.MicroAlgos ).
Prepare the Ledger implementation for that change by deprecating the accountUpdates.Totals and naming it OnlineTotals. As such, it would return just the online portion of that structure ( i.e. totals.Online.Money ).
Test Plan
Ran existing tests on Ledger.OnlineTotals