-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: remove batch verification flag #3781
crypto: remove batch verification flag #3781
Conversation
1dd6801
to
ac8eb28
Compare
ac8eb28
to
1a11785
Compare
Codecov Report
@@ Coverage Diff @@
## master #3781 +/- ##
==========================================
+ Coverage 49.80% 54.49% +4.68%
==========================================
Files 409 390 -19
Lines 68929 48411 -20518
==========================================
- Hits 34332 26382 -7950
+ Misses 30891 19803 -11088
+ Partials 3706 2226 -1480
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that someone else (maybe @cce ?) has reviewed the work that went into making sure this PR is safe (where we looked at all past verifies). But judging this just for removing the enable flag, this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the node was caught up from block 1 to the latest under extended verification settings, looks good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I guess I should close #3783 since it is asserting both cases of EnableBatchVerification when true and false?
Summary
On V32 we introduced the batch verification for ed25519 signatures. In order to sync all nodes on the new algorithm, we added a new consensus param field.
Since the network accepted the V32 version, we can use the new algorithm on historical signatures.
Test Plan
Run full catchup test on Testnet, betanet and main net while configuring the node the verify signatures for old blocks.