Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into feature/320-rounds #3942

Merged

Conversation

algorandskiy
Copy link
Contributor

No description provided.

algorandskiy and others added 3 commits May 1, 2022 19:20
In some situations the method might incorrectly count
deleted items towards total items. This might result
not returning all the resources to REST API clients.
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #3942 (035def5) into feature/320-rounds (f18bbed) will decrease coverage by 0.02%.
The diff coverage is 28.57%.

@@                  Coverage Diff                   @@
##           feature/320-rounds    #3942      +/-   ##
======================================================
- Coverage               50.07%   50.05%   -0.03%     
======================================================
  Files                     412      412              
  Lines                   70641    70646       +5     
======================================================
- Hits                    35376    35364      -12     
- Misses                  31411    31424      +13     
- Partials                 3854     3858       +4     
Impacted Files Coverage Δ
ledger/ledgercore/accountresource.go 0.00% <0.00%> (ø)
ledger/acctupdates.go 69.53% <100.00%> (+0.30%) ⬆️
network/wsPeer.go 65.83% <0.00%> (-2.78%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18bbed...035def5. Read the comment docs.

@algorandskiy algorandskiy merged commit c10cdda into algorand:feature/320-rounds May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants