e2e tests: Fixes for e2e test runs #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
approved these changes
May 4, 2022
This was referenced May 27, 2022
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small quality of life fixes for e2e tests that I've run into issues with.
Summary
e2e.shwhen we fail to set theE2E_PLATFORMvariable, the shell will complain that we are using a binary operator (==) on a single argument. Setting the left side of the test statement to a string with variable interpolation fixes this.stdoutandstderrvariables which causes an exception inreportcomms(p, stdout, stderr)when the except block runs afterp.communicateraises an exception. Initializing to None fixes this.Test Plan
Found and fixed while running e2e tests in failure scenarios.